Skip to content

Removed m1 specific docker compose. Added buildx commands.#73

Merged
smalho01 merged 3 commits intodevfrom
rems-374-m1
May 8, 2023
Merged

Removed m1 specific docker compose. Added buildx commands.#73
smalho01 merged 3 commits intodevfrom
rems-374-m1

Conversation

@kennyEung
Copy link
Copy Markdown
Contributor

Describe your changes

A solution to target multiple platforms was found using Docker's buildx command. This PR builds images targeted for the amd64 (linux x86), arm64 (M1), and amd64 (windows x86). This removed M1 specific docker compose files and docker files.

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@smalho01 smalho01 self-assigned this May 3, 2023
Comment thread docker-compose-m1.yml
Comment thread .github/workflows/docker-cd-dev.yml
@smalho01
Copy link
Copy Markdown
Collaborator

smalho01 commented May 8, 2023

update readme documentation and set up guides!

@smalho01 smalho01 merged commit 8b01484 into dev May 8, 2023
@smalho01 smalho01 deleted the rems-374-m1 branch May 8, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants